[1.8.2 BLOCKER] #12447

[gibson042]

No new test because I'm not really sure how to identify potentially nonterminating inputs.

Sizes - compared to master @ 6bc2a87

    259990        (+8)  dist/jquery.js                                         
     92802        (+7)  dist/jquery.min.js                                     
     33216        (-1)  dist/jquery.min.js.gz

[mikesherov]

0.0001 seems like a magic number here. Can we be certain that this condition gets met?

[gibson042]

It is a magic number, and... no. The choice of how good a fit to demand while protecting ourselves against nontrivial loops is arbitrary.

[mikesherov]

My only other thought is that we might want to put in an iteration counter as a failsafe? Also arbitrary, but guaranteed to terminate.

[dmethvin]

How many iterations would you make through here, and would the starting value get a lot better after dozens of iterations? If the infinite loop is the exception then a small failsafe loop counter might be easier to deal with and a heck of a lot less mysterious.