Skip to content

Gruntfile.js indented properly#106

Closed
ashg1910 wants to merge 2 commits intojquery:masterfrom
ashg1910:master
Closed

Gruntfile.js indented properly#106
ashg1910 wants to merge 2 commits intojquery:masterfrom
ashg1910:master

Conversation

@ashg1910
Copy link

No description provided.

@arthurvr
Copy link
Member

From http://contribute.jquery.org/style-guide/js/#full-file-closures:

module.exports = function( grunt ) {

// This doesn't get indented

};

Also, we use tabs, no spaces.

@arthurvr arthurvr closed this Mar 29, 2015
@ashg1910
Copy link
Author

@arthurvr I indented this so that it is easy to read

@arthurvr
Copy link
Member

@ashg1910 It being easier to read is at the end just a personal opinion. This is how our style guide states it, and that's where the whole team agrees on.

When an entire file is wrapped in a closure, the body of the closure is not indented.

@ashg1910
Copy link
Author

okay :)
And what is the tabspace you use?
8 or 4?

@arthurvr
Copy link
Member

And what is the tabspace you use?
8 or 4?

That does not make sense, we use 'real' tabs, no spaces :)

@arschmitz
Copy link
Member

@arthurvr this actually does matter because it effects our max line length rules. We use real tabs but count them as 4 space.

Lines should be no longer than 80 characters, and must not exceed 100 (counting tabs as 4 spaces).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants