Skip to content

Previous and Next Navigation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darcyclarke opened this issue Nov 22, 2011 · 11 comments
Closed

Previous and Next Navigation #31

darcyclarke opened this issue Nov 22, 2011 · 11 comments

Comments

@darcyclarke
Copy link
Contributor

Will do, just making an issue to track tasks.

@addyosmani
Copy link
Member

@darcyclarke just bumping :) Are tasks like this one from November now complete or are they still pending? If they're done, could you possibly close the ones you were working on (that are ready) on the issue tracker? I'd like to do a clear up so we know what areas still need further work.

Cheers!

@johnkpaul
Copy link
Contributor

This is an issue in web-base-template and 2012-dev-summit. I think this can be closed. jquery/2012-dev-summit#91

@RedWolves
Copy link
Member

Closed issue in jquery/2012-dev-summit#91 this is the authoritative issue on feedback.

@johnkpaul
Copy link
Contributor

Once jquery/jquery-wp-content#83 is merged, this issue will be fixed.

@rdworth
Copy link
Contributor

rdworth commented Nov 21, 2012

While the referenced web-base-template issue is closed, it seems there's a different issue here. The Previous and Next buttons both (and always) say "Getting Started with jQuery Mobile"

@ajpiano
Copy link
Member

ajpiano commented Nov 21, 2012

not sure what's going on here, i'll try to debug it today once i finish a few content things

@rdworth
Copy link
Contributor

rdworth commented Nov 21, 2012

Seems this issue only exists on stage. I wasn't able to reproduce locally.

@gnarf
Copy link
Member

gnarf commented Nov 22, 2012

stage is running wordpress 3.5-alpha-21206 -- It seems the WP_Query is not adding the menu order to the query... This worked on my local which was 3.4.2. Live is still using 3.4

Should we upgrade stage/live wordpress versions?

/cc @nacin

https://gist.github.com/5ab30e34ff2f3b0279d9

@nacin
Copy link
Member

nacin commented Nov 22, 2012

Ordering by menu order was added in WP revision 21748. My code assumes that if you're running 3.5, you're running the latest (especially since it is not "stable" yet). No need to change the code, just update stage.

Live should be running 3.4.2. If I can be taught how to keep WP updated via this configuration, I can make sure bugfix and security releases get immediately applied.

Stage should probably be running 3.5 which will be 3.5-RC1 in the next few hours.

@gnarf
Copy link
Member

gnarf commented Nov 22, 2012

I'll upgrade these tomorrow... I did notice one thing btw, http://jquery.com/wp-admin/network/ is an infinite redirect atm. Dunno when we broke that, but it's probably my fault when I tweaked the nginx config?

@gnarf
Copy link
Member

gnarf commented Nov 24, 2012

Wordpress 3.5-RC1 works, closing this.

@gnarf gnarf closed this as completed Nov 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

8 participants