Skip to content

event-helpers.md .toggle description inconsistent with API docs #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjparrott opened this issue Jun 21, 2013 · 3 comments
Closed

event-helpers.md .toggle description inconsistent with API docs #382

mjparrott opened this issue Jun 21, 2013 · 3 comments

Comments

@mjparrott
Copy link

On the event helpers section of learn.jquery.com, it says the .toggle function is to be given 2 or more functions that are called when an onclick event occurs.

However, the .toggle method description in the documentation talks about it being used to toggle the visibility of elements.

It looks like the first usage was deprecated in 1.8 and removed in 1.9, so this should probably be updated to show its newer usage.

See:
http://api.jquery.com/toggle-event/
http://api.jquery.com/toggle/
http://learn.jquery.com/events/event-helpers/

@AurelioDeRosa
Copy link
Member

This is a very old issue but the page still discusses about .toggle(). While it asserts the method has been removed in jQuery 1.9, the example is still there. I think it should be completely removed. What do you all think?

@mgol
Copy link
Member

mgol commented Jul 7, 2014

Yeah, we shouldn't teach people how to write code using deprecated features. ;)

AurelioDeRosa added a commit to AurelioDeRosa/learn.jquery.com that referenced this issue Jul 7, 2014
Deleted example of the `toggle()` method removed in jQuery 1.9, as discussed in issue jquery#382.
@arthurvr
Copy link
Member

PR: #529.

Krinkle pushed a commit that referenced this issue Apr 9, 2024
…oved in jQuery 1.9, as discussed in issue #382.

fixes gh-382
closes gh-529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants