Skip to content

Doc on document.ready should indicate if multiple declarations will conflict #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
David-dp- opened this issue Jul 15, 2016 · 5 comments · Fixed by #721
Closed

Doc on document.ready should indicate if multiple declarations will conflict #719

David-dp- opened this issue Jul 15, 2016 · 5 comments · Fixed by #721

Comments

@David-dp-
Copy link

In page learn.jquery.com/page/using-jquery-core/document-ready.md there is no indication whether a later declaration of document.ready (perhaps in a library) would overwrite or compose an earlier declaration (perhaps in another library). If it would overwrite, it would be helpful to indicate what error might be reported.

@dmethvin
Copy link
Member

To keep the learning documentation lean I think it's better to only introduce the concepts here and refer people to the API documentation for details. Otherwise we are duplicating too much and when things change or need clarification we have to do it in multiple places.

@AurelioDeRosa
Copy link
Member

I agree with Dave about the duplication of information. I think that adding a link to the API page should be enough.

@David-dp-
Copy link
Author

Thanks for pointing out that there's a separate API reference. It appeared
to me that I was already reading the API reference.

On 18 July 2016 at 03:16, Aurelio De Rosa notifications@github.com wrote:

I agree with Dave about the duplication of information. I think that
adding a link to the API page should be enough.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#719 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsVQ0A06oSM7h1uSLkFsvGihJP7SxgHks5qWkdUgaJpZM4JNh7-
.

@David-dp-
Copy link
Author

FWIW, the API page you provided doesn't answer my question, either. I can't
find any widget on the page to provide feedback, but if there is one,
please let me know.

On 3 August 2016 at 14:04, David accounts accts@intentionperception.org
wrote:

Thanks for pointing out that there's a separate API reference. It appeared
to me that I was already reading the API reference.

On 18 July 2016 at 03:16, Aurelio De Rosa notifications@github.com
wrote:

I agree with Dave about the duplication of information. I think that
adding a link to the API page should be enough.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#719 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsVQ0A06oSM7h1uSLkFsvGihJP7SxgHks5qWkdUgaJpZM4JNh7-
.

@dmethvin
Copy link
Member

dmethvin commented Aug 6, 2016

I'll clarify when it's rewritten in jquery/api.jquery.com#964

@dmethvin dmethvin closed this as completed Aug 6, 2016
Krinkle pushed a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants