Skip to content

missing text #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
taoliu12 opened this issue Jan 12, 2017 · 3 comments
Closed

missing text #744

taoliu12 opened this issue Jan 12, 2017 · 3 comments

Comments

@taoliu12
Copy link

taoliu12 commented Jan 12, 2017 •
edited
Loading

The first step to code organization is separating pieces of your application into distinct pieces; sometimes, even just this effort is sufficient to lend ???????????????????

https://learn.jquery.com/code-organization/concepts/
@AurelioDeRosa
Copy link
Member

AurelioDeRosa commented Jan 16, 2017 •
edited
Loading

Thank you for reporting the broken sentence. Without knowing the original intention of the author is hard to tell what the conclusion of the sentence was. However, I think this should make it:

The first step to code organization is separating pieces of your application into distinct pieces; sometimes, even just this effort is sufficient to improve the structure of your code and its maintainability.

Any opinion?

@ramyashankaran
Copy link
Contributor

I am a first-timer with contributing on Github. The complete sentence by @AurelioDeRosa looks correct for the topic of encapsulation. Can I take a shot at updating this page?

@AurelioDeRosa
Copy link
Member

Hi @ramyashankaran.

Yes, we love contributions. Go for it.

ramyashankaran added a commit to ramyashankaran/learn.jquery.com that referenced this issue Feb 4, 2017
@ramyashankaran
Issue 744 Missing Text
ac817ac 
Component: Content file under Code-Organization

Replaced incomplete text.

Fixes jquery#744
ramyashankaran added a commit to ramyashankaran/learn.jquery.com that referenced this issue Feb 4, 2017
@ramyashankaran
Issue 744 missing text (#1)
451c03e 
* Missing Text fix

Fixed "Encapsulation" section which had missing text in
Pages/Code-Organization/Contents

* Revert "Missing Text fix"

This reverts commit 5037cca.

* Issue 744 Missing Text

Component: Content file under Code-Organization

Replaced incomplete text.

Fixes jquery#744
Krinkle pushed a commit that referenced this issue Apr 9, 2024
@ramyashankaran @Krinkle
code-organization: Fix incomplete sentence under "Encapsulation"
84c2a7a 
Fixed "Encapsulation" section which had missing text.

The incomplete "is sufficient to lend" sentence has been here as early
as the first 2011 commit of the book that the site was based on:

https://github.com/rmurphey/jqfundamentals/blob/55eb9dd5d5779b884fdafbe6673b04a5d0c97733/book/part3-advanced-topics/ch10-code-organization.html

Closes #748.
Fixes #744.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AurelioDeRosa @taoliu12 @ramyashankaran