Skip to content

Added the 'How do I...' FAQs for issue #71 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2012
Merged

Added the 'How do I...' FAQs for issue #71 #135

merged 2 commits into from
Oct 16, 2012

Conversation

RedWolves
Copy link
Member

Added the FAQs that Adam and I talked about today.

@addyosmani
Copy link
Member

Nice work @RedWolves! I noticed that you opted for the triple ticks + js over just triple ticks that we've had other contributions from the summit use. @ajpiano do we want to standardise on which we use?

@RedWolves
Copy link
Member Author

This is for issue #71.

@RedWolves
Copy link
Member Author

@addyosmani Talked with @ajpiano. I'll remove the language specification as it'll be easier for contributors to contribute to just use the ticks instead of ticks + language.

I'll fix and resubmit.

@ajpiano
Copy link
Member

ajpiano commented Oct 16, 2012

Going forward, we're going to leave off the language unless it is required to resolve a particular ambiguity, should one arise.

@addyosmani
Copy link
Member

Thanks for clarifying @ajpiano!. Appreciate the effort to resubmit @RedWolves :)

@RedWolves
Copy link
Member Author

Ok I pushed and this is ready again for review.

@addyosmani
Copy link
Member

Cheers! Looks good for a merge.

addyosmani added a commit that referenced this pull request Oct 16, 2012
Added the 'How do I...' FAQs for issue #71
@addyosmani addyosmani merged commit 772f98b into jquery:master Oct 16, 2012
arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
Added the 'How do I...' FAQs for issue jquery#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants