Skip to content

#68 other libs #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

#68 other libs #163

wants to merge 5 commits into from

Conversation

ericladd
Copy link
Contributor

This supersedes pull request from Issue #160.

@rwaldron
Copy link
Member

Can we enforce the core style guide on learn.jquery.com examples?

@dmzza
Copy link
Contributor

dmzza commented Oct 16, 2012

A bit of confusion occurred here. Much of the content in event-basics.md was already rewritten in handling-events.md (whose file renaming is waiting in PR #154). Once PR #154 is merged, we want to copy the content on .one() from event-basics.md into handling-events.md. The rest of event-basics.md should be discarded, as it was only a reorganizing of other content.

/using-jquery-core/avoid-conflicts-other-libraries.md is also useful, and should be merged as is. That is unrelated to event-basics and handling-events.

order.yml should be discarded. PR #154 has a more updated version of order.yml

@rwaldron
Copy link
Member

No confusion necessary... I'm asking you to pioneer the updating of examples!

@dmzza
Copy link
Contributor

dmzza commented Oct 16, 2012

Our confusion is unrelated to your comment. Although yes, I agree with the style guide. I made an effort to follow it in handling-events.md

@ericladd
Copy link
Contributor Author

Core style guide is being added to the repo and a ticket will be opened to review all code examples for conformance.


```
// Event setup using a convenience method
$('p').click(function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quotes

@rwaldron
Copy link
Member

I started doing inline comments... but look out for whitespace, double quotes and stuff... I'm tired.

@bobholt
Copy link
Member

bobholt commented Oct 16, 2012

While new content should conform to core styles, I'm working on #29 to update existing examples.

@ajpiano ajpiano mentioned this pull request Nov 2, 2012
@ajpiano
Copy link
Member

ajpiano commented Nov 2, 2012

Now that #154 is merged and there's a separate PR for style guide conformance, it's a bit challenging to make heads or tails of this PR. Any chance you can help out and do a revised PR that will merge more cleanly @dmzza @ericladd, then we can close this one?

@addyosmani
Copy link
Member

Following up on @ajpiano's comments, @dmzza @ericladd is there still interest in revising this PR?

@rmurphey
Copy link
Contributor

@addyosmani @dmzza @ericladd @ajpiano see #211, which should allow this to be closed :)

@addyosmani
Copy link
Member

Thanks @rmurphey and nice work on the other PR! Closing this in favor of it.

@addyosmani addyosmani closed this Dec 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants