-
Notifications
You must be signed in to change notification settings - Fork 481
#68 other libs #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#68 other libs #163
Conversation
Can we enforce the core style guide on learn.jquery.com examples? |
A bit of confusion occurred here. Much of the content in event-basics.md was already rewritten in handling-events.md (whose file renaming is waiting in PR #154). Once PR #154 is merged, we want to copy the content on .one() from event-basics.md into handling-events.md. The rest of event-basics.md should be discarded, as it was only a reorganizing of other content. /using-jquery-core/avoid-conflicts-other-libraries.md is also useful, and should be merged as is. That is unrelated to event-basics and handling-events. order.yml should be discarded. PR #154 has a more updated version of order.yml |
No confusion necessary... I'm asking you to pioneer the updating of examples! |
Our confusion is unrelated to your comment. Although yes, I agree with the style guide. I made an effort to follow it in handling-events.md |
Core style guide is being added to the repo and a ticket will be opened to review all code examples for conformance. |
|
||
``` | ||
// Event setup using a convenience method | ||
$('p').click(function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double quotes
I started doing inline comments... but look out for whitespace, double quotes and stuff... I'm tired. |
While new content should conform to core styles, I'm working on #29 to update existing examples. |
@addyosmani @dmzza @ericladd @ajpiano see #211, which should allow this to be closed :) |
Thanks @rmurphey and nice work on the other PR! Closing this in favor of it. |
This supersedes pull request from Issue #160.