-
Notifications
You must be signed in to change notification settings - Fork 481
Rewrote queue article this resolves #77 #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I dig it. Only comment is to make sure the code examples comply with jQuery Core Styles. I'm going through existing content to close #29, so we should make sure any new commits comply. (Double quotes, and some spacing issues were the things I saw here). |
@bobholt 👍 |
@gnarf37 This PR is meant to address issue #77, which is to consolidate the old queue/dequeue article with your stackoverflow post, which is currently in the learn site archive as well. Can you give a quick review here and see if this achieves that end acceptably? Also @bentonam, can you push a commit removing the "uses_of_queue_and_dequeue.md" (@gnarf's post) as well as the entry from order.yml? Thanks. |
If you could resolve the merge conflicts while this is being reworked that would also ease landing this. Thanks :) |
Ping @bentonam |
( stealing this issue to test something - sorry! ) |
@bentonam @gnarf37 Do you think we could wrap up the work on this PR in the new year so we can bring it in? :) |
I still think this is an improvement over the existing article. Is there really anything else remaining here or do you think the branch just needs to be cleaned up so it can merge cleanly @gnarf37 ? |
I'm okay with the content. Just need a rebar I think
|
If you can sign our CLA, I can clean this up and get it merged, @bentonam. Actually, @bobholt, if you could sign the CLA as well, we should have one on file for you as you've already got a bunch of commits on this repo too! |
We've asked for a CLA and can't merge without it. Going to close this for now. @bentonam i'd really like to take this change in, but it needs a rebase and someone to look over it again. If you're willing could you please sign the CLA and take a look at it again? |
This article was dated and needed to be rewritten. I am interested to hear your thoughts on it.