Skip to content

Correct malformed regex in example #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Correct malformed regex in example #305

wants to merge 1 commit into from

Conversation

douglascalhoun
Copy link
Contributor

No description provided.

@alimony
Copy link

alimony commented Mar 11, 2013

FWIW, this fix is also part of the previously opened pull request #283.

@ajpiano
Copy link
Member

ajpiano commented Mar 14, 2013

Thanks for reporting these @douglascalhoun (this issue as well as #302 and #303) -- unfortunately (or fortunately, depending on your perspective) they got fixed up by @alimony in his earlier pull requests which were just merged. Will try to do a better job getting fixes merged sooner so we don't end up with duplicate pull requests like this again :) Should you continue to find errors, please do report them again!

@ajpiano ajpiano closed this Mar 14, 2013
@douglascalhoun
Copy link
Contributor Author

No worries. I just wanted to help out as this is an excellent resource you are providing.

Besides, I got #307 in. Woohoo! Official contributor!

Keep up the good work!

On Thursday, March 14, 2013 at 9:52 AM, adam j. sontag wrote:

Thanks for reporting these @douglascalhoun (https://github.com/douglascalhoun) (this issue as well as #302 (#302) and #303 (#303)) -- unfortunately (or fortunately, depending on your perspective) they got fixed up by @alimony (https://github.com/alimony) in his earlier pull requests which were just merged. Will try to do a better job getting fixes merged sooner so we don't end up with duplicate pull requests like this again :) Should you continue to find errors, please do report them again!


Reply to this email directly or view it on GitHub (#305 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants