Skip to content

Style fixes in the jQuery Mobile section. #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Style fixes in the jQuery Mobile section. #329

wants to merge 3 commits into from

Conversation

alimony
Copy link

@alimony alimony commented Apr 10, 2013

See commit messages for details.

Markus Amalthea Magnuson added 2 commits April 10, 2013 15:37
Style fixes to the jQuery Mobile section.
2c98db3 
Code changes:
* Spaces to tabs.
* Lower-case doctype tag.
* Always use self-closing HTML elements.
* Fix incorrect "/header" comment.
Style fixes to the jQuery Mobile section.
d5992f0 
Style fixes:
* Oxford commas.
* Title case headers.
* `<tagname>` instead of `tagname` for inline HTML code.
* A few word reshuffles for sentence clarity.
* Double instead of single quotes in body text.
* …various bits and pieces.
@alimony
Copy link
Author

alimony commented May 2, 2013

So, what's happening with these pull requests? It's been three weeks now :)

eddiemonge
eddiemonge reviewed May 16, 2013
View reviewed changes
page/jquery-mobile/getting-started.md

```
<!DOCTYPE html>
<!doctype html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed the style used in the examples in the jQuery HTML style guide: http://contribute.jquery.org/style-guide/html/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lowercase tags is always correct.

@alimony
Copy link
Author

alimony commented May 17, 2013

Fixed the self-closing (doh!) tags now.

@ajpiano ajpiano closed this in 96f6894 May 17, 2013
@ajpiano
Copy link
Member

ajpiano commented May 17, 2013

Thanks @alimony. I'm aiming to trim this backlog of PRs today and then connect with you about setting you up as a repo collaborator!!

@alimony
Copy link
Author

alimony commented May 21, 2013

@ajpiano Cool, seems like all of them are merged now. I still have a few pages to go through, having repo access when doing so could definitely keep the workload down for the rest of you. I could help out with some of the others' pull requests too. How do we set this up? And how should it work? Do I still open PRs based on feature branches, but merge them myself?

Thanks for spending some time with my pull requests :)

arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
@ajpiano
Style fixes to the jQuery Mobile section. Fixes jquery#329.
0791a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alimony @ajpiano @eddiemonge @scottgonzalez