Improve error callback example for $.ajax #372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error handler includes two of the three parameters, but doesn't actually do anything with them. This is a very common place where new developers will get the "Sorry, there was a problem!" and not know how to go further to figure out what the problem was. Adding the logging may help improve that.
|
Should the console's be commented out with a note to uncomment them to see the actual error responses in case anyone does a copy and paste into their actual code without realizing that console could break some browsers? (CLA signed) |
arthurvr
pushed a commit
to arthurvr/learn.jquery.com
that referenced
this pull request
Jan 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handler includes two of the three parameters, but doesn't actually do anything with them. This is a very common place where new developers will get the "Sorry, there was a problem!" and not know how to go further to figure out what the problem was. Adding the logging may help improve that.