Skip to content

Improve article attribution heuristic #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jugglinmike
Copy link
Contributor

Make the attribution algorithm trace through the history
across file rename operations, but do not consider such operations as an
indication of contribution.

The compiled output is a single line of JSON, making it a bit tough to inspect.
Here's what I did to try it out:

$ git checkout -b tmp master
$ grunt
$ git add -f dist
$ git commit -m "Current build"
$ git pull git@github.com:jugglinmike/learn.jquery.com.git follow-moves
$ grunt
$ git diff --word-diff --word-diff-regex="[^,\{]"

Basically, it adds contributors who created/edited articles prior to 0fb17c3 (including yours truly) and removes contributors whose only interaction with an article was to move it (i.e. @rdworth in 0711375 and 7b49f82).

Make the attribution algorithm trace through the history
across file rename operations, but do not consider such operations as an
indication of contribution.
@ajpiano
Copy link
Member

ajpiano commented Jun 6, 2013

This is awesome, @jugglinmike. I'll give it a try but this solves a real problem that I didn't think we had a solution for! Have you signed the CLA? If not, now's a good time!

@rdworth
Copy link
Contributor

rdworth commented Jun 6, 2013

Thank you @jugglinmike . This has been bothering me for a while, so I'm happy to have a solution in sight

@jugglinmike
Copy link
Contributor Author

I have indeed signed the CLA. Don't you guys remember my monumental contribution to jQuery core?

@ajpiano ajpiano closed this in 23791d3 Jun 6, 2013
arthurvr pushed a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
Make the attribution algorithm trace through the history
across file rename operations, but do not consider such operations as an
indication of contribution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants