remove a wrong word #443
remove a wrong word #443
Conversation
The `foo` variable is a local variable in the code. if the variable is a global variable, that function `myFn` can see changes to the variable value too, so i removed the word 'global'.
|
Thanks for taking the time to contribute to the jQuery project! Can you sign the CLA? As for the change, the key thing here is that the variable is declared outside of the function definition. I agree current wording is unfortunate but your change also doesn't explain what's really happening. Can you adjust the wording? |
|
@mzgol Thanks for your reply! When i visited the CLA page, there was some error happend, like this, "Refused to display 'https://accounts.google.com/ServiceLogin?service=wise&passive=1209600&conti…s.google.com%2Fembeddedform%3Fformkey%3DdFJucXdGZXlRdVh2SUVUb2hsb0FBYkE6MQ' in a frame because it set 'X-Frame-Options' to 'DENY'. " Maybe it's my network problems, I'll try it later. For the change, adjust the wording to explain what's really happening, Did you mean it's because closures? |
|
@ethrea1 There are some weird issues with Google Docs. Can you try using a different browser? Sometimes that helps. We haven't been able to figure out what the problem is, but I do have a plan to eventually work around the issue altogether. |
|
@ethrea1 I'm saying that if the variable was declared inside the function then it's destroyed after the function returns. An important thing here is that the variable is declared outside of the function; the |
|
More accurate wording would be something like "when you reference a variable from a parent scope" though I don't know if "parent scope" is technically correct. @rwaldron can likely provide the correct wording. |
|
|
|
@scottgonzalez Maybe it's my network problems, i have signed CLA. Thank you! |
|
This was handled in b137fd2. |
The
foovariable is a local variable in the code. if the variable is a global variable, that functionmyFncan see changes to the variable value too, so i removed the word 'global'.