JavaScript 101 Types: Removed new Object suggestion
#543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ajpiano @kswedberg @rwaldron for review/further edit suggestions please? |
|
Yeah, definitely 👍 |
| alert( people[ "person1" ].firstName ); | ||
| alert( people[ "person2" ].firstName ); | ||
| ``` | ||
|
|
||
| If a property is accessed that has not been defined, it will return a type of `undefined`. | ||
| If a property is accessed that has not been defined, it will be the value `undefined`. |
There was a problem hiding this comment.
will have the value, rather than be the value?
|
@gnarf: Much better! |
|
Updated with Karl's suggestion - going to wait for at least one more set of eyes before landing |
| people[ "person1" ] = person1; | ||
| people[ "person2" ] = person2; | ||
|
|
||
| // Access properties using a mix of both bracket and dot notaion |
|
Other than the one typo, this looks good. |
|
Fixed typo and landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"The simplest way" is to use an object literal. None of us use
new Objectwe shouldn't even mention it.