Skip to content

Comma must be escaped too. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Comma must be escaped too. #557

wants to merge 1 commit into from

Conversation

christianrank
Copy link
Contributor

No description provided.

@arthurvr
Copy link
Member

@jecoopr Seems like you haven't signed the CLA, could you handle that? Make sure the name and email in your git config matches the name and email you signed the CLA with.

@RedWolves
Copy link
Member

Ping @christianrank can you sign our CLA so we can land this?

@arthurvr you @ mentioned the wrong person here too.

@christianrank
Copy link
Contributor Author

Yes, I've done that now.

@RedWolves
Copy link
Member

@christianrank I am just now reviewing this in more detail. I am having trouble trying to figure out the use case that would require a comma to be escaped in this example. Can you provide one?

@christianrank
Copy link
Contributor Author

I was working on a website where IDs with commas are used,
but i couldn't select them with jQuery, so I searched and found this function and had to escape the comma too.

@arthurvr
Copy link
Member

I am just now reviewing this in more detail. I am having trouble trying to figure out the use case that would require a comma to be escaped in this example. Can you provide one?

It does not make that much sense in this example, but people might be picking up the function/regex for 'real' work. If you don't get the point http://jsfiddle.net/zttmccxv/1/ might explain it. The thing is that the comma has a special meaning in css, so must be escaped when passing it to jQuery() as an ID.

@arthurvr arthurvr closed this in 71ca7f3 Jan 31, 2015
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants