Skip to content

Added missing 'within' in the last paragraph. #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jaredchua32
Copy link

Hello, I was reading the article and I noticed that there was a missing word in the last paragraph so I put it there. Thank you jQuery team!

Jared

@arthurvr
Copy link
Member

@jecoopr Looks good. You haven't signed the CLA, could you handle that? Make sure the name and email in your git config matches the name and email you signed the CLA with.

@RedWolves
Copy link
Member

Ping @jaredchua32 can you sign our CLA so we can land this PR?

@arthurvr who did you @ mention in your comment? LOL

@jaredchua32
Copy link
Author

I have just signed the CLA, I apologize for taking long! If anything else is missing please let me know. Thank you so much!

@RedWolves
Copy link
Member

@jaredchua32 unfortunately your email you signed the CLA with doesn't match the email in your git config. Can you sign with that email address please?

git config user.email <- will get the email address

@jaredchua32
Copy link
Author

I'm sorry for the delay as I have two emails. I have signed the CLA using the email associated to my GitHub so it should be the correct one.

@arthurvr
Copy link
Member

@jaredchua32 Seems like it still isn't right. The email on the commit is ***ed@jaredchua.com, you've signed using that one?

@jaredchua32
Copy link
Author

I have just signed using that one. I totally forgot that I had changed my config email a while ago! Will the third time be the charm?

@agcolom
Copy link
Member

agcolom commented Jan 18, 2015

@jaredchua32 Thank you for signing the CLA. It all seems fine this time.

@arthurvr arthurvr closed this in 8ea5be8 Jan 19, 2015
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants