Skip to content

Update key-concepts with XDomainRequest limitation #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2016

Conversation

moo3
Copy link
Contributor

@moo3 moo3 commented Nov 12, 2014

Added this update in order to clarify the understanding implied in the sentence 'This limitation does not apply to scripts that are loaded via jQuery's Ajax methods'. This will help the beginner to understand $.ajax does not work seamlessly with every browser, but only with help of some plugins.

Added this update in order clarify the understanding implied in the sentence 'This limitation does not apply to scripts that are loaded via jQuery's Ajax methods'. This will help the beginner to understand $.ajax does not work seamlessly with every browser, but only with help of some plugins.
@arthurvr
Copy link
Member

@moo3 Seems like you haven't signed the CLA, could you handle that? Make sure the name and email in your git config matches the name and email you signed the CLA with.

@arthurvr
Copy link
Member

arthurvr commented Jan 4, 2015

Looks like CLA is okay now. Somebody may remove the label.

@moo3
Copy link
Contributor Author

moo3 commented Jan 6, 2015

Great. Let me know if its good for merge.

@RedWolves
Copy link
Member

@dmethvin would you mind doing a quick review?

@dmethvin
Copy link
Member

dmethvin commented Jan 7, 2015

It seems a bit vague for the learn site. Something more straightforward would be "Versions of Internet Explorer less than 10 do not support cross-domain AJAX requests." XDR is not really a very good substitute but you could reference it.

@arthurvr
Copy link
Member

Hey-hey @moo3, still interested in taking this PR? It needs some updating (see comment above)

@arthurvr
Copy link
Member

ping ping @moo3

@arthurvr
Copy link
Member

hey @moo3! This is something we'd like to have in, but some updates need to happen. See @dmethvin's comments. Would you mind doing those? Thanks!

Removed direct references to XDR and also the link to jQuery ticket, which is now a dead link.
@arthurvr
Copy link
Member

@moo3 Next time, can you leave a comment after making changes? If you don't do that we don't get notified.

@dmethvin Can you give this another review? Thanks.

@dmethvin
Copy link
Member

LGTM now.

@arthurvr
Copy link
Member

Alright. I'll merge this one when I get home.

@dmethvin dmethvin merged commit 018aff8 into jquery:master Apr 30, 2016
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
* Update key-concepts with XDomainRequest limitation
* Update IE's limited support info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants