-
Notifications
You must be signed in to change notification settings - Fork 480
Basic Plugin Creation: remove confusing sentence #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@scottgonzalez @jzaefferer Could you please take a look and see whether you're happy with the change. Thanks. |
Honestly, utility methods have no place in this article. I'd say all references to them should be removed. |
Nah... Makes sense you understand the difference when creating a plugin. I mean... you must know where to put your methods. In this article there's nothing more than just this 3 sentences explaining the difference. |
What percentage of developers do you think should be creating utility method plugins? I'd say it's near 0%. |
You think so? I don't agree, but I'll update my PR this evening. |
So, what percentage? What are the use cases? |
Other suggestion: move the utility method related stuff to 'advanced plugin concepts'. |
I would agree with @scottgonzalez here. Many if not most utility methods that currently exist are only on the |
@agcolom @arschmitz @scottgonzalez Updated the pr. |
There are still references, including a heading. |
8b17b6b
to
b93b04f
Compare
@scottgonzalez Indeed. Updated. |
There's still this reference:
Since we're in the plugin creation section, not the intro to jQuery section, I don't think this is relevant. |
There are also still utility methods being generated in code examples. |
@scottgonzalez Updated once again. Sorry man! |
@scottgonzalez @agcolom @arschmitz Friendly ping for somebody to merge some stuff here and there. 50 open PRs isn't really encouraging for new contributors to join... 😒 (sorry if I'm I'm asking to the wrong people, I don't really know who to ask) |
This sentence was confusing (#396) and didn't make sense. Replaced with a better example.
Update: As discussed, totally removed it.