Skip to content

Basic Plugin Creation: remove confusing sentence #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arthurvr
Copy link
Member

@arthurvr arthurvr commented Dec 5, 2014

This sentence was confusing (#396) and didn't make sense. Replaced with a better example.

Update: As discussed, totally removed it.

@arthurvr
Copy link
Member Author

Just for ref: this would fix #509 and #528 too... Seems like two issues were open.

@agcolom
Copy link
Member

agcolom commented Dec 15, 2014

@scottgonzalez @jzaefferer Could you please take a look and see whether you're happy with the change. Thanks.

@scottgonzalez
Copy link
Member

Honestly, utility methods have no place in this article. I'd say all references to them should be removed.

@arthurvr
Copy link
Member Author

Honestly, utility methods have no place in this article. I'd say all references to them should be removed.

Nah... Makes sense you understand the difference when creating a plugin. I mean... you must know where to put your methods.

In this article there's nothing more than just this 3 sentences explaining the difference.

@scottgonzalez
Copy link
Member

What percentage of developers do you think should be creating utility method plugins? I'd say it's near 0%.

@arthurvr
Copy link
Member Author

What percentage of developers do you think should be creating utility method plugins? I'd say it's near 0%.

You think so? I don't agree, but I'll update my PR this evening.

@scottgonzalez
Copy link
Member

So, what percentage? What are the use cases?

@arthurvr
Copy link
Member Author

Other suggestion: move the utility method related stuff to 'advanced plugin concepts'.

@arschmitz
Copy link
Member

I would agree with @scottgonzalez here. Many if not most utility methods that currently exist are only on the $ as a namespace if people are creating utilities they should not be on the $ namespace they should use their own namespace.

@arthurvr
Copy link
Member Author

@agcolom @arschmitz @scottgonzalez Updated the pr.

@scottgonzalez
Copy link
Member

There are still references, including a heading.

@arthurvr arthurvr force-pushed the patch-1 branch 3 times, most recently from 8b17b6b to b93b04f Compare December 16, 2014 13:40
@arthurvr
Copy link
Member Author

@scottgonzalez Indeed. Updated.

@scottgonzalez
Copy link
Member

There's still this reference:

Note that the notion of chaining is not applicable to jQuery utility methods like $.trim().

Since we're in the plugin creation section, not the intro to jQuery section, I don't think this is relevant.

@scottgonzalez
Copy link
Member

There are also still utility methods being generated in code examples.

@arthurvr
Copy link
Member Author

@scottgonzalez Updated once again. Sorry man!

@arthurvr
Copy link
Member Author

@scottgonzalez @agcolom @arschmitz Friendly ping for somebody to merge some stuff here and there. 50 open PRs isn't really encouraging for new contributors to join... 😒 (sorry if I'm I'm asking to the wrong people, I don't really know who to ask)

@agcolom agcolom closed this in c381a51 Dec 18, 2014
@arthurvr
Copy link
Member Author

Thanks, @agcolom! #509 can be closed now too.

@arthurvr arthurvr deleted the patch-1 branch December 18, 2014 23:05
arthurvr added a commit to arthurvr/learn.jquery.com that referenced this pull request Jan 4, 2015
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants