Skip to content

Javascript-101/testing-type: format type correctly #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arthurvr
Copy link
Member

Three little corrections to the formatting of a a type in javascript-101/testing-type:

  • The type itself must not have a capital O. It's not a constructor.
> typeof []
'object'
  • It's 'code', so it must be wrapped within backticks.
  • The dot ending the sentence must be outside of the backticks.

@kswedberg
Copy link
Member

Since object is enclosed in back-ticks, you're right that the period should appear outside the quotation mark. However, if the word remained in quotation marks, then it would be correct (in American English, which is what we use for jQuery's documentation) to keep the period inside the ending quotation mark.

I hope I'm not coming off as pedantic. I just wanted to note it here in case you come across similar uses of quotation marks in the future.

@arthurvr
Copy link
Member Author

True. Was a miswording of mine.

@RedWolves RedWolves closed this in 095b8bc Jan 6, 2015
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants