using-jquery-core/utility-methods: add type checking section #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dmethvin can you give this a review? |
Member
There was a problem hiding this comment.
I would just let people read the docs for the details, to keep this simple.
3743c09 to
35ee056
Compare
Member
Author
|
@RedWolves @dmethvin Updated my PR. |
Member
|
👍 |
35ee056 to
72f8b3e
Compare
page/javascript-101/testing-type.md
Outdated
Member
There was a problem hiding this comment.
The link doesn't work it goes to /javascript-101/using-jquery-core/utility-methods.md#testing-type
You don't need the ../
You also don't need the .md
Member
There was a problem hiding this comment.
you do need a leading /
this will work /using-jquery-core/utility-methods#testing-type
72f8b3e to
dac22f2
Compare
Member
Author
|
@RedWolves Any more review on this? |
Member
|
nope looks good. Want to go ahead and land this? You have access now it looks like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds info about type checking utility methods to
using-jquery-core/utility-methods. Would fix #404 on the while.