Attributions: replace contributor list by link in /about
#603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2015
| @@ -28,6 +28,10 @@ The first is Rebecca Murphey's [jQuery Fundamentals](http://jqfundamentals.com/l | |||
|
|
|||
| The second is [docs.jquery.com](http://docs.jquery.com), that erstwhile chestnut still living out its final days before it will be shut down in early 2013. Since we've moved the API documentation for jQuery Core off that domain, we needed a place that could serve a similar need – documentation (that anyone can contribute to) that gets into the "how-to" and FAQs – without clumsy barriers to entry like finding the right person to set you up with a special wiki account and forcing all authoring into a `<textarea>`. | |||
|
|
|||
| ## Contributing | |||
|
|
|||
| This project wouldn't have been possible without all our [awesome contributors](https://github.com/jquery/learn.jquery.com/graphs/contributors?type=a). If you feel like something on the site is open for improvements, you can contribute [on Github](https://github.com/jquery/learn.jquery.com). Feel free to check out [the contributing guide](contributing/) for more in-depth information. | |||
e3e4830 to
c91500a
Compare
| @@ -128,7 +51,7 @@ jqueryContent.postPreprocessors.page = (function() { | |||
| post.menuOrder = menuOrder; | |||
| } | |||
|
|
|||
| contributorAttribution( post, postPath, callback ); | |||
| callback(null, post); | |||
There was a problem hiding this comment.
This needs spaces around the arguments.
There was a problem hiding this comment.
Of course. I'm living with too many style guides these days. Will update.
c91500a to
a147fb4
Compare
|
@scottgonzalez PR updated again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be sure things don't break, this must be merged together with jquery/jquery-wp-content#334. Don't merge this yet!
This together with the other PR would close #602.
It replaces the contributors section under every page with an shoutout in the
about/page.