Skip to content

javascript-101/arrays: add info on second parameter of .slice() #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arthurvr
Copy link
Member

Fixes #611

@arthurvr
Copy link
Member Author

@RedWolves @gnarf @agcolom Somebody who wants to review this?

@gnarf
Copy link
Member

gnarf commented Jan 18, 2015

Can't line comment from mobile, but you can just call .slice with no parameters and get a copy of the array.

@arthurvr
Copy link
Member Author

Oh yeah, correct. Fixing it now.

@gnarf
Copy link
Member

gnarf commented Jan 18, 2015

Other than that extra 'required' you snuck in, it looked good to me 😉
On Jan 18, 2015 1:40 PM, "Arthur Verschaeve" notifications@github.com
wrote:

Oh yeah, correct. Fixing it now.


Reply to this email directly or view it on GitHub
#612 (comment)
.

@arthurvr arthurvr closed this in 3296aa2 Jan 19, 2015
@arthurvr arthurvr deleted the arraySlice branch January 19, 2015 16:46
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Array.slice() method documentation needs correction
2 participants