Update types.md #619
Closed
Update types.md #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the URI of standard built-in objects in JavaScript.
Add title for the URI of standard built-in objects in MDN.
|
Done, thanks. |
| @@ -66,7 +66,7 @@ var bar2; | |||
|
|
|||
| ## Objects | |||
|
|
|||
| Everything else in JavaScript is considered an object. While there are [numerous built-in objects](https://developer.mozilla.org/en/JavaScript/Reference#Global_Objects, "MDN - Global Object Reference"), this chapter will cover: | |||
| Everything else in JavaScript is considered an object. While there are [numerous built-in objects](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects "MDN - Standard built-in objects"), this chapter will cover: | |||
There was a problem hiding this comment.
"MDN - Global Object Reference" seems better than "MDN - Standard built-in objects" to me. (that's what was in originally)
There was a problem hiding this comment.
I'm aware of that, but the title of the new page is "Standard built-in objects". If you think the old title/link is better, then I should also change the link to the right version of the old one (the old link without the extra comma and with language redirection) for consistency. WDYT?
There was a problem hiding this comment.
Agreed. It's okay as the PR is now. If no people disagree I'll merge it in this evening.
Krinkle
pushed a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the URI of standard built-in objects in JavaScript.