Update avoid-conflicts-other-libraries.md #627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wording seems ambiguous, this more directly states the end reality.
| @@ -123,7 +123,7 @@ jQuery.noConflict(); | |||
| </script> | |||
| ``` | |||
|
|
|||
| Note that if you use this technique, you will not be able to use prototype.js methods inside the immediately invoked function that expect `$` to be prototype.js's `$`. | |||
| Note that if you use this technique, you will not be able to use prototype.js methods inside the immediately invoked function. `$` will be a reference to jQuery, not prototype.js. | |||
There was a problem hiding this comment.
$will be a reference to jQuery, not prototype.js.
Should the extension be there? I would opt to not have it in.
There was a problem hiding this comment.
If you are referring to 'prototype.js', I would rather leave it that way so as to avoid confusing the library with the concept of prototype.
|
@amalinich Looks like you haven't signed our CLA yet. Could you do so? |
|
@arthurvr done |
|
Can you ensure that the git author information matches the name and email you signed with? |
|
This should be done, I was using a different github email than I thought. |
|
To me the CLA look good right now. Thanks @amalinich |
Krinkle
pushed a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wording seems ambiguous, this more directly states the end reality.