-
Notifications
You must be signed in to change notification settings - Fork 481
Remove project-specific contribution guidelines #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR for the theme: jquery/jquery-wp-content#343 |
So the team has decided not to have contributing guidelines linked from the top nav? As I said before, fixing #554 has nothing to do with the contributing page on the site. I just want to make sure this isn't being done without forethought. I have followed all of the discussions, but I don't recall a discussion about removing this link. |
The current
Why do we need that link? We would still have a link to the contributing guidelines: http://gyazo.com/6f30f5dab0c82e4ccdffc177776b6fcd, so a second link to slightly different documentation is only more confusing. We can always bring project-specific guidelines back when we need them, but atm this page doesn't provide any value and only confuses people. |
Only because there's a link. They are in fact two separate files with different paths and one just happens to point to the other. Fixing one does not require changing the other.
I didn't say it was needed. I asked if the team had discussed this.
But the confusion was something else. There are details in the page about how to actually contribute to the content. I have not reviewed the content to see if all the important information is already covered. This is why I didn't say +1 or -1, but simply asked if this was discussed. |
@agcolom You have any thoughts on this? |
@arthurvr There seems to be info there that is needed and I don't really want us to lose useful info such as everything that is related to adding a new article, which is something specific to the learn site. While I'm all for consistency, I don't see the harm in having project specific contributing guidelines for this site as its nature is somewhat different to the other sites that we have. |
Yeah, It might be better to limit the project-specific guidelines to topics that aren't the covered on http://contribute.jquery.org/web-sites/ tho. I think I'll update this PR to just remove all guidelines that aren't project-specific, keeping all stuff specific to this site in and linking up contribute.jquery.org at the top. Would that be a better solution? |
Unfortunately I wasn't part of the whole discussion, so I'm not sure if this PR is still relevant. @agcolom can you recall anything on top of your mind? |
I'm not sure it's still relevant judging lack of response for almost 2 years. I'll close it then; we can still reopen if it turns out it's still relevant. |
Removes our project-specific
contributing.md
page. These were basically duplicate of the contribute.jquery.org site. Similar to the way other projects are doing it.Would fix #554. Please don't merge yet, this needs a PR for the theme in
jquery-wp-content
too. There is still a link in the header.