-
Notifications
You must be signed in to change notification settings - Fork 481
Widget Factory duplicated page on plugins #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for contributing @sigorilla! We will need to review both articles to see if there's no unique content in @scottgonzalez This is regarding an article originally written by you, so I'd like to have your feedback on this. |
I wrote both of them, they're nearly identical. http://learn.jquery.com/jquery-ui/widget-factory/how-to-use-the-widget-factory/ is essentially just a copy of http://blog.nemikor.com/2010/05/15/building-stateful-jquery-plugins/ updated for the new API and switching to our standard documentation namespace. The original article was copied into jQuery Fundamentals, ultimately ending up at http://learn.jquery.com/plugins/stateful-plugins-with-widget-factory/. Note: I never submitted the content. The plugins article can just go away, but I think the current wording in the plugins page is lacking. Look at the intro of the article that's going away for some more descriptive text. |
Yes, I definitely agree. @sigorilla You'd like to give it an update? |
@arthurvr Yes, I will update description based on your requirements. Can I use first three paragraphs for this update? |
page/plugins.md
Outdated
|
||
In order to fill this gap, jQuery UI has implemented a more advanced plugin system. The new system manages state, allows multiple functions to be exposed via a single plugin, and provides various extension points. This system is called the Widget Factory and is exposed as `jQuery.widget` as part of jQuery UI 1.8; however, it can be used independently of jQuery UI. | ||
|
||
To demonstrate the capabilities of the Widget Factory, we'll build a simple progress bar plugin. For details on writing this plugin, see [How To Use the Widget Factory](/jquery-ui/widget-factory/how-to-use-the-widget-factory/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To demonstrate the capabilities of the Widget Factory, we'll build a simple progress bar plugin.
This might confuse people as now that tutorial will live in another section. Maybe change the sentence around a bit to clarify?
Will probably need to setup a redirect from the old page as well? |
@arthurvr Redirect should be like |
@sigorilla You shouldn't really care about setting up the redirects, we'll make sure that gets done. At the moment it isn't really possible from inside a repo yet. |
@arthurvr Sorry, I was a little busy. So I updated last sentence as you asked. |
Follows-up a2a01a4. * Before the merging of these two pages, the two were not exaclty identical. History: https://github.com/jquery/learn.jquery.com/commits/aefe20bae4/page/plugins/stateful-plugins-with-widget-factory.md including: - Fix rendering negative progressbar value 48242d8 - "native event" -> "jQuery event" 4fda0f1 * Maintain a redirect, especially since it appears that the page we removed was the more popular one in terms of search ranking. Ref #636
Follows-up a2a01a4. * Before the merging of these two pages, the two were not exaclty identical. History: https://github.com/jquery/learn.jquery.com/commits/aefe20bae4/page/plugins/stateful-plugins-with-widget-factory.md including: - Fix rendering negative progressbar value 48242d8 - "native event" -> "jQuery event" 4fda0f1 * Maintain a redirect, especially since it appears that the page we removed was the more popular one in terms of search ranking. Ref #636
I tried fixed #335.
Remove
stateful-plugins-with-widget-factory.md
fromplugins/
. And link up the page in the UI section.P.S. Sorry for last PR (#635).