Skip to content

Widget Factory duplicated page on plugins #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

sigorilla
Copy link
Contributor

I tried fixed #335.

Remove stateful-plugins-with-widget-factory.md from plugins/. And link up the page in the UI section.

P.S. Sorry for last PR (#635).

@sigorilla sigorilla changed the title Widget Factory duplicated page on Plugins Widget Factory duplicated page on plugins Mar 6, 2015
@arthurvr
Copy link
Member

Thanks for contributing @sigorilla! We will need to review both articles to see if there's no unique content in stateful-plugins-with-widget-factory. I don't really have time to do that at the moment but will come back to this shortly.

@scottgonzalez This is regarding an article originally written by you, so I'd like to have your feedback on this.

@scottgonzalez
Copy link
Member

I wrote both of them, they're nearly identical. http://learn.jquery.com/jquery-ui/widget-factory/how-to-use-the-widget-factory/ is essentially just a copy of http://blog.nemikor.com/2010/05/15/building-stateful-jquery-plugins/ updated for the new API and switching to our standard documentation namespace. The original article was copied into jQuery Fundamentals, ultimately ending up at http://learn.jquery.com/plugins/stateful-plugins-with-widget-factory/. Note: I never submitted the content.

The plugins article can just go away, but I think the current wording in the plugins page is lacking. Look at the intro of the article that's going away for some more descriptive text.

@arthurvr
Copy link
Member

The plugins article can just go away, but I think the current wording in the plugins page is lacking. Look at the into of the article that's going away for some more descriptive text.

Yes, I definitely agree. @sigorilla You'd like to give it an update?

@sigorilla
Copy link
Contributor Author

@arthurvr Yes, I will update description based on your requirements.

Can I use first three paragraphs for this update?

page/plugins.md Outdated

In order to fill this gap, jQuery UI has implemented a more advanced plugin system. The new system manages state, allows multiple functions to be exposed via a single plugin, and provides various extension points. This system is called the Widget Factory and is exposed as `jQuery.widget` as part of jQuery UI 1.8; however, it can be used independently of jQuery UI.

To demonstrate the capabilities of the Widget Factory, we'll build a simple progress bar plugin. For details on writing this plugin, see [How To Use the Widget Factory](/jquery-ui/widget-factory/how-to-use-the-widget-factory/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To demonstrate the capabilities of the Widget Factory, we'll build a simple progress bar plugin.

This might confuse people as now that tutorial will live in another section. Maybe change the sentence around a bit to clarify?

@arthurvr
Copy link
Member

Will probably need to setup a redirect from the old page as well?

@sigorilla
Copy link
Contributor Author

@arthurvr Redirect should be like page/contributing.md? Or some other way?

@arthurvr
Copy link
Member

arthurvr commented Jun 6, 2015

@sigorilla You shouldn't really care about setting up the redirects, we'll make sure that gets done. At the moment it isn't really possible from inside a repo yet.

@sigorilla
Copy link
Contributor Author

@arthurvr Sorry, I was a little busy. So I updated last sentence as you asked.

Base automatically changed from master to main March 8, 2021 17:15
@Krinkle Krinkle merged commit a2a01a4 into jquery:main Apr 9, 2024
Krinkle added a commit that referenced this pull request Apr 9, 2024
Follows-up a2a01a4.

* Before the merging of these two pages, the two were not exaclty
  identical. History:
  https://github.com/jquery/learn.jquery.com/commits/aefe20bae4/page/plugins/stateful-plugins-with-widget-factory.md
  including:
  - Fix rendering negative progressbar value
    48242d8
  - "native event" -> "jQuery event"
    4fda0f1

* Maintain a redirect, especially since it appears that the page we
  removed was the more popular one in terms of search ranking.

Ref #636
@sigorilla sigorilla deleted the issue335 branch April 12, 2024 07:58
Krinkle added a commit that referenced this pull request Apr 12, 2024
Follows-up a2a01a4.

* Before the merging of these two pages, the two were not exaclty
  identical. History:
  https://github.com/jquery/learn.jquery.com/commits/aefe20bae4/page/plugins/stateful-plugins-with-widget-factory.md
  including:
  - Fix rendering negative progressbar value
    48242d8
  - "native event" -> "jQuery event"
    4fda0f1

* Maintain a redirect, especially since it appears that the page we
  removed was the more popular one in terms of search ranking.

Ref #636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Widget Factory tutorial content sort of duplicated
6 participants