Skip to content

Conversation

@AchoArnold
Copy link
Contributor

@arschmitz
Copy link
Member

@najela why should we ignore those? They seem like perfectly valid url's there are no redirects or anything? It also looks like you fixed them in this PR?

@AchoArnold
Copy link
Contributor Author

image
@arschmitz Looking at Link 2 and Link 3 above, you'll see that the source links are those 2 links I posted earlier.

@scottgonzalez
Copy link
Member

Looks like the links need to be fixed to use HTTPS instead of HTTP.

@scottgonzalez
Copy link
Member

Oh, no, that's not it. I'm not sure why the output shows the URL with HTTP. Anyway, the difference is the trailing slash.

@scottgonzalez
Copy link
Member

I figured out where the HTTP comes from. The non-slashed HTTPS URL is getting a 301 to the slashed HTTP URL, which is getting a 307 to the slashed HTTPS URL.

@AchoArnold
Copy link
Contributor Author

@scottgonzalez I've updated the PR as per your suggestions.

@scottgonzalez
Copy link
Member

Can you please update this so it will merge cleanly?

@AchoArnold
Copy link
Contributor Author

@scottgonzalez All good? Sorry for the wait 😏

@scottgonzalez
Copy link
Member

The changes look good to me, though it's odd that there's a paragraph rewrite mixed in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the addition of a new blank line in here? They're unrelated changes and there being 2 lines would be inconsistent.

@arthurvr
Copy link
Member

arthurvr commented Jun 6, 2015

The links all look good to me but I'd prefer the rewrite of a paragraph not to go inside of a commit to fix links. I like the changes so maybe @najela can extract the changes to that paragraph to its own commit? That would be awesome :)

@arthurvr
Copy link
Member

Friendly ping @najela.

@AchoArnold
Copy link
Contributor Author

Things have been crazy for me this past month but I'll fix this by sunday.

@arthurvr
Copy link
Member

Thank you @najela.

@AchoArnold
Copy link
Contributor Author

I've updated this

@AchoArnold
Copy link
Contributor Author

Any Updates?

@AurelioDeRosa AurelioDeRosa self-assigned this Mar 13, 2016
@AurelioDeRosa
Copy link
Member

I'm going to take a look at this PR tomorrow. Thank you for your patient and for the PR.

@AchoArnold
Copy link
Contributor Author

Any updates @AurelioDeRosa

@mgol mgol closed this Mar 8, 2021
@mgol mgol deleted the branch jquery:master March 8, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

8 participants