-
Notifications
You must be signed in to change notification settings - Fork 475
Fix links 2015 04 26 #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links 2015 04 26 #651
Conversation
|
@najela why should we ignore those? They seem like perfectly valid url's there are no redirects or anything? It also looks like you fixed them in this PR? |
|
|
|
Looks like the links need to be fixed to use HTTPS instead of HTTP. |
|
Oh, no, that's not it. I'm not sure why the output shows the URL with HTTP. Anyway, the difference is the trailing slash. |
|
I figured out where the HTTP comes from. The non-slashed HTTPS URL is getting a 301 to the slashed HTTP URL, which is getting a 307 to the slashed HTTPS URL. |
|
@scottgonzalez I've updated the PR as per your suggestions. |
|
Can you please update this so it will merge cleanly? |
|
@scottgonzalez All good? Sorry for the wait 😏 |
|
The changes look good to me, though it's odd that there's a paragraph rewrite mixed in. |
page/ajax/ajax-events.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the addition of a new blank line in here? They're unrelated changes and there being 2 lines would be inconsistent.
|
The links all look good to me but I'd prefer the rewrite of a paragraph not to go inside of a commit to fix links. I like the changes so maybe @najela can extract the changes to that paragraph to its own commit? That would be awesome :) |
|
Friendly ping @najela. |
|
Things have been crazy for me this past month but I'll fix this by sunday. |
|
Thank you @najela. |
|
I've updated this |
|
Any Updates? |
|
I'm going to take a look at this PR tomorrow. Thank you for your patient and for the PR. |
|
Any updates @AurelioDeRosa |

Hey @arschmitz, Please ignore the following links