Changes reflecting deprecated methods: Issue Ticket 665 #669
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
|
Cripes, I definitely have the same details in git config and the CLA signature! Can someone please look into this for me and confirm I do. I resubmitted CLA form and globally changed my git config to match before even forking the second time, so at a loss to this CLA Fail. |
|
@citygent I don't see a signature with your name nor email or any combination of them in our signature list. If you click the details link next to the error it tells you exactly what name and email it expects to find in the list based on the info used to commit the change. |
|
Hi @kborchers Do you mean this? Top and bottom match :) |
|
Right, they match because that is where the checker got that information but that information is not in the signature database. My guess is if you sign the CLA with that information this check will turn green. |
|
Not sure why this seems to have fixed itself. Maybe I was expecting the CLA check to update quicker than it does. Apologies! |
| ``` | ||
|
|
||
| **Note:** A note about the `dataType` setting: if the server sends back data that is in a different format than you specify, your code may fail, and the reason will not always be clear, because the HTTP response code will not show an error. When working with Ajax requests, make sure your server is sending back the data type you're asking for, and verify that the `Content-type` header is accurate for the data type. For example, for JSON data, the `Content-type` header should be `application/json`. | ||
|
|
||
| **Deprecation:** Deprecation Notice: The jqXHR.done(), jqXHR.fail(), and jqXHR.always() callbacks are used above, but you may see the older jqXHR.success(), jqXHR.error(), and jqXHR.complete() callbacks, and should update the code accordingly: As of jQuery 1.8 these are deprecated and will eventually be removed. |
There was a problem hiding this comment.
This is more something for API docs IMHO. Keep in mind that most people are here to learn and use api.jquery.com as a reference. I feel like we shouldn't bother them with deprecated stuff they should be aware of just yet.
|
Apologies it has taken so long to address your notes, @arthurvr |
|
LGTM 👍 |
New pull request, had some issues before with CLA and resetting author.