Skip to content

Conversation

@qzaqza1818
Copy link

It had my attention because I discovered it during the reading of this documentation, thus it may confuse users by refer them to the wrong example.

typo problem
@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@qzaqza1818 qzaqza1818 closed this Oct 9, 2015
@qzaqza1818 qzaqza1818 reopened this Oct 9, 2015
@qzaqza1818 qzaqza1818 closed this Oct 9, 2015
@qzaqza1818 qzaqza1818 reopened this Oct 9, 2015
@AurelioDeRosa
Copy link
Member

@qzaqza1818 can you please sign the CLA?

@agcolom
Copy link
Member

agcolom commented Jan 21, 2016

@qzaqza1818 Thank you very much for taking the time to complete a PR. In order to accept your pull request, we first need you to accept our contributor's license agreement by signing it (see details above).

However, your GH account currently doesn't have your real name, so even if you signed it now, the CLA check would fail as it would check your name against the name submitted in the PR which here is your username. So here's my suggestion:

  • Update your github profile and add your real name.
  • Sign our CLA.
  • Close this PR and do a new one (which will be associated with your real name and for which the CLA check will pass).

I realise the inconvenience this may cause, but it also means that it will be easier for you to get your PRs accepted on any repository you wish to contribute to.

Many thanks,

Anne

@qzaqza1818 qzaqza1818 closed this Jan 28, 2016
@AurelioDeRosa
Copy link
Member

Hi @qzaqza1818.

Are you going to submit another PR for this or you are not interested anymore?

@qzaqza1818
Copy link
Author

Yes I will try to submit another PR.

@qzaqza1818 qzaqza1818 deleted the patch-1 branch January 28, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants