Skip to content

Update append-outside-loop.md to use string buffer instead of string concatenation #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maschwenk
Copy link

From my research, this method is much faster.

From my research, this method is much faster.
@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@maschwenk
Copy link
Author

I have signed CLA

@scottgonzalez
Copy link
Member

Faster, but not much faster. In 99% of user code the difference will be meaningless, so I'd prefer to keep this out of general recommendations.

@AurelioDeRosa
Copy link
Member

I'd keep the code as it is as well.

@arthurvr
Copy link
Member

Thanks for the suggestion, though!

@arthurvr arthurvr closed this Oct 26, 2015
@maschwenk
Copy link
Author

Sure, no problem. Thanks for review. I was coming off trying to optimize an IE8 string concatenation...where this kind of thing unfortunately matters, but agree that it doesn't belong in these docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants