-
Notifications
You must be signed in to change notification settings - Fork 480
Explicitly describe $ as an alias for jQuery #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -53,6 +53,8 @@ $( document ).ready(function() { | |||
}); | |||
``` | |||
|
|||
<div class="warning">**Note**: The jQuery library exposes its methods and properties via two properties of the <code>window</code> object called <code>jQuery</code> and <code>$</code>. <code>$</code> is simply an alias for <code>jQuery</code> and it's often employed because it's shorter and faster to write.</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should this be in a class="warning"
box? Might as well just have a normal paragraph about this. The warnings always give me the feeling something is a gotcha or something could go wrong, but in this case it's just a concept being introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it doesn't flow well with the rest of the discussion which has another focus, so I put it in a "aside" bar.
@AurelioDeRosa We could use either a normal note or a div class="note" which gives a blue box if I remember correctly. |
@agcolom This is more of a general comment but I've checked the |
@AurelioDeRosa I think you can land your PR :-) |
Thank you for the review @agcolom. I'm going to merge it now. |
Fixes gh-680