Skip to content

Update dont-repeat-yourself.md #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

captainkovalsky
Copy link

Added approaches with filter function and ES6 example

Added approaches with filter function and ES6 example
@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@scottgonzalez
Copy link
Member

I think we should avoid ES6 on this site. Especially when it's not supported in all browsers.

@agcolom
Copy link
Member

agcolom commented Nov 4, 2015

I agree with @scottgonzalez. I can save this PR for later and label it ES6?

@scottgonzalez
Copy link
Member

I think it will be quite a while before we'd want ES6 on this site. Long enough that keeping PRs open would be a bad idea.

@agcolom agcolom added the ES6 label Nov 5, 2015
@agcolom
Copy link
Member

agcolom commented Nov 5, 2015

@scottgonzalez agreed.
@vdzundza Thank you very much for the PR. We will close it for now, but label it ES6, so that we can revisit it when ES6 is fully supported and feel it should be par of the learn site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants