optimize-selectors qSA before Sizzle#694
Conversation
There was a problem hiding this comment.
I think this example might need a small introduction. Even 1-2 sentences should do it.
|
Hi @mr21. Are you still interested in this PR? |
|
... I'm really sorry, yes I'm still interested. |
|
@mr21 Make sure you rebase from here before continuing your work. I merged a PR based on another issue and removed/rearranged a bunch of stuff, so you might have conflicts. |
|
Understood :) |
78fd9d4 to
cb2c81b
Compare
|
Hi :) So, I have rebased and repush again my commit with the @AurelioDeRosa's modifications. |
|
Hi @mr21. With "yet" you mean that you'll add another commit to update the PR? |
|
Hi :) For the moment I have replaced this: ID-Based SelectorsBeginning your selector with an ID is a safe bet. // Fast:
$( "#container div.robotarm" );
// Super-fast:
$( "#container" ).find( "div.robotarm" );With the first approach, jQuery queries the DOM using by this: Save calls to
|
|
I've confirmed from the previous CLA data that this PR was indeed signed as the bot originally indicated: {
"data":{
"commits":[{
"hash":"cb2c81b5816f112368c34090f4214bf613c1b881",
"email":"thomastortorini@gmail.com",
"name":"Thomas Tortorini"
}],
"neglectedCommits":[],
"neglectedAuthors":[]
},
"state":"success",
"description":"All authors have signed the CLA"
} |
Hi :)
Here a first draft (who probably contain few mistakes) for the issue #666.