Updated themes description as per the two swatches #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
agcolom
reviewed
Feb 6, 2017
page/jquery-mobile/theme-roller.md
Outdated
|
|
||
| All items in containers inherit the swatch from their parent. Exceptions to this rule are the listdivider in listviews, the header of nested list pages, and the button of split button lists, which all default to "b" (blue in the default theme). Count bubbles default to "c" (silver in the default theme). | ||
| All items in containers inherit the swatch from their parent. Exceptions to this rule are the listdivider in listviews, the header of nested list pages, and the button of split button lists, which all default to "b" (blue in the default theme). |
There was a problem hiding this comment.
This doesn't look correct. Listdividers are not blue in the default theme. Please check all these in detail (color as well as default swatch for component.
There was a problem hiding this comment.
Sorry for the mistakes, I am still learning about jQM. So, I have compared the demos of the newer version and the older version. As per the comparision, listdivider in listviews do inherit the the swatch from their parent, the default swatch being "a" where it is light gray. The same goes for buttons of split button list and nested list pages.
Is my inference appropriate?
page/jquery-mobile/theme-roller.md
Outdated
|
|
||
| ### Themes and Swatches | ||
|
|
||
| The theme system separates color and texture from structural styles that define things like padding and dimensions. This allows theme colors and textures to be defined once in the stylesheet and to be mixed, matched, and combined to achieve a wide range of visual effects. | ||
|
|
||
| Each theme includes several global settings, including font family, drop shadows for overlays, and corner radius values for buttons and boxes. In addition, the theme can include multiple color swatches, each with color values for bars, content blocks, buttons and list items, and font text-shadow. | ||
|
|
||
| The default theme includes five swatches that are given letters (a, b, c, d, e) for quick reference. To make mapping of color swatches consistent across our widgets, we have followed the convention that swatch "a" is the highest level of visual priority (black in our default theme), "b" is secondary level (blue), "c" is the baseline level (gray) that we use by default in many situations, "d" for an alternate secondary level, and "e" as an accent swatch. Themes may have additional swatches for accent colors or specific situations. For example, you could add a new theme swatch "f" that has a red bar and button for use in error situations. | ||
| The default theme includes two swatches that are given letters (a, b) for quick reference. Themes may have additional swatches for accent colors or specific situations. For example, you could add a new theme swatch "f" that has a red bar and button for use in error situations. |
There was a problem hiding this comment.
Since we only have a and b, you should use c for the new theme swatch for continuity.
page/jquery-mobile/theme-roller.md
Outdated
|
|
||
| Note that there is also a swatch named "active" (bright blue in the default theme) which is used to indicate an active selected item. See the global "Active" state further down this page for more information on the active swatch. | ||
|
|
||
| The page loading dialog and error message don't inherit a swatch theme. The loading dialog defaults to swatch "a" (black in the default theme) and the error message to swatch "e" (yellow in the default theme). You can configure those defaults globally. | ||
| The page loading dialog and error message don't inherit a swatch theme. The loading dialog defaults to swatch "a" (black in the default theme). You can configure those defaults globally. |
There was a problem hiding this comment.
Please check colors and default swatch for component.
page/jquery-mobile/theme-roller.md
Outdated
|
|
||
| ### Default Theme Swatch Mapping for Components | ||
|
|
||
| If no theme swatch letter is set at all, the framework uses the "a" swatch (black in the default theme) for headers and footers and the "c" swatch (light gray in the default theme) for the page content to maximize contrast between the both. | ||
| If no theme swatch letter is set at all, the framework uses the "a" swatch (black in the default theme) for headers and footers. |
There was a problem hiding this comment.
a isn't black in the default theme anymore
Corrected colors for components Corrected dialog overlay details
|
Corrected descriptions. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #685 . Please review.