Don't say that callbacks execute only at the end of the parent #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's misleading because they can be executed anywhere in the parent, even multiple times (indeed functions accepting "callbacks" that operate on array items will call the function on each iteration). Simplify the wording here to explain only that the parent function can call it, without all the extra stuff which convolutes the definition.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's misleading because they can be executed anywhere
in the parent, even multiple times (indeed functions accepting
"callbacks" that operate on array items will call the function
on each iteration).
Simplify the wording here to explain only that the parent
function can call it, without all the extra stuff which convolutes
the definition.