Skip to content

Randomly generated id attribute #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asdfgh11111 opened this issue Aug 9, 2017 · 2 comments
Closed

Randomly generated id attribute #405

asdfgh11111 opened this issue Aug 9, 2017 · 2 comments

Comments

@asdfgh11111
Copy link

Hi, I'm trying to figure out why our app has big delay in Edge. The case quite trivial. I have wizard with couple forms. Delay appears on switching from one form to another.

Here is what I found in dev tools:
image

Seems our app performance quite suffer from internally generated id attribute which triggers style recalculation. It's just one expanded on the screen but there are dozen "offsetWidth"s below.

Any ideas how to except it?

PS win64, Microsoft Edge 40.15063.0.0, Microsoft EdgeHTML 15.15063
@gibson042
Copy link
Member

We generate that id to ensure that all components of compound selectors match children of the context element (e.g., so $ul.find("ul li") runs code like ul.querySelectorAll("#id-of-ul ul li") instead of the naïve ul.querySelectorAll("ul li"), which would match all the descendant <li> elements). But we skip generation/assignment if the context element already has an id, so the best thing you can do is ensure that it does before invoking a selection.

@asdfgh11111
Copy link
Author

Set id to form and got 1s instead of 4s. Other recalculations seems not related to selectors.
Though, hope u sure querySelector worth it :)

@mgol mgol mentioned this issue Aug 9, 2019
Closed
mgol added a commit to mgol/jquery that referenced this issue Aug 9, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
466a369 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquerygh-4453
Ref jquerygh-4332
Ref jquery/sizzle#405
@mgol mgol mentioned this issue Aug 9, 2019
Merged
2 tasks
mgol added a commit to mgol/jquery that referenced this issue Aug 9, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
22fff98 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquerygh-4453
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Aug 12, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
0b62852 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquerygh-4453
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Aug 12, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible (no EdgeHTM…
d02998e 
…L support)

The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquerygh-4453
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to jquery/jquery that referenced this issue Aug 19, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
df6a7f7 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes gh-4453
Closes gh-4454
Ref gh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/sizzle that referenced this issue Aug 19, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
f03e74e 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes gh-4453
Closes gh-4454
Ref gh-4332
Ref jquery#405
mgol added a commit to mgol/sizzle that referenced this issue Aug 19, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
021a452 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
@mgol mgol mentioned this issue Aug 19, 2019
Merged
mgol added a commit to mgol/sizzle that referenced this issue Aug 20, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
4662d2b 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit to mgol/sizzle that referenced this issue Aug 20, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
53b7f5d 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit to mgol/sizzle that referenced this issue Aug 21, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
ce1b1b7 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit to mgol/sizzle that referenced this issue Aug 21, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
b5d89e2 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit to mgol/sizzle that referenced this issue Aug 21, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
b79a069 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit to mgol/sizzle that referenced this issue Aug 21, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
59d5c24 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit to mgol/jquery that referenced this issue Aug 26, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible (no EdgeHTM…
d0a579c 
…L support)

The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquerygh-4453
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/sizzle that referenced this issue Oct 1, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
dd77de0 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref jquerygh-405
mgol added a commit that referenced this issue Oct 10, 2019
@mgol
Selector: Leverage the :scope pseudo-class where possible
0f4bd29 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Fixes jquery/jquery#4453
Closes gh-453
Ref jquery/jquery#4454
Ref jquery/jquery#4332
Ref gh-405
mgol added a commit to mgol/jquery that referenced this issue Sep 8, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
a4e1381 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Sep 12, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
3b5f92c 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Sep 19, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
e300235 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Sep 21, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
745d3b0 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Oct 3, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
6629a80 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Oct 4, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
7346b20 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Nov 17, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
70c5484 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Dec 1, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
a90f1da 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
mgol added a commit to mgol/jquery that referenced this issue Dec 13, 2022
@mgol
Selector: Leverage the :scope pseudo-class where possible
f95c2c3 
The `:scope` pseudo-class[1] has surprisingly good browser support: Chrome,
Firefox & Safari have supported if for a long time; only IE & Edge lack support.
This commit leverages this pseudo-class to get rid of the ID hack in most cases.
Adding a temporary ID may cause layout thrashing which was reported a few times
in [the past.

We can't completely eliminate the ID hack in modern browses as sibling selectors
require us to change context to the parent and then `:scope` stops applying to
what we'd like. But it'd still improve performance in the vast majority of
cases.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/:scope

Ref jquerygh-4453
Ref jquerygh-4454
Ref jquerygh-4332
Ref jquery/sizzle#405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gibson042 @asdfgh11111