Skip to content

Fix jQuery #10799: detect buggy getElementsByName#113

Closed
gibson042 wants to merge 1 commit intojquery:masterfrom
gibson042:jquery_10799
Closed

Fix jQuery #10799: detect buggy getElementsByName#113
gibson042 wants to merge 1 commit intojquery:masterfrom
gibson042:jquery_10799

Conversation

@gibson042
Copy link
Member

Updates #81 for the Sizzle rewrite.

http://bugs.jquery.com/ticket/10799

In IE, document.getElementsByName limits its results to "form controls" (@name-aware HTML4 elements) if it finds a match amongst them. To prevent inaccurate results from making it out of Sizzle, this pull request makes the NAME shortcut dependent upon more reliable behavior from that method.

Net effect on jQuery master @ 330eb3bb79708761c897d66cf961c3eb5450c53c:

    255231      (+112)  dist/jquery.js
     92213        (+6)  dist/jquery.min.js
     33171       (-11)  dist/jquery.min.js.gz

@gibson042 gibson042 mentioned this pull request Jul 3, 2012
@timmywil
Copy link
Member

timmywil commented Jul 3, 2012

nice work

@timmywil timmywil closed this in fbdc818 Jul 3, 2012
markelog pushed a commit to markelog/sizzle that referenced this pull request May 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants