Fix jQuery #12606: stop cache keys from conflicting with Object.prototype properties#157
Closed
gibson042 wants to merge 3 commits intojquery:masterfrom
Closed
Fix jQuery #12606: stop cache keys from conflicting with Object.prototype properties#157gibson042 wants to merge 3 commits intojquery:masterfrom
gibson042 wants to merge 3 commits intojquery:masterfrom
Conversation
Member
|
We should rethink the structure of the cache before adding strange keys like this. I don't understand the problem yet though. |
Member
|
Ok, I see now. That's kinda funny. |
Member
|
Yeah, came in expecting a boring |
markelog
pushed a commit
to markelog/sizzle
that referenced
this pull request
May 26, 2013
…ct.prototype properties. Closes jquerygh-157.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net effect on jQuery master @ c3b1367f4c19abf12eadc1460a37dc34ae765e1b