Build: Update grunt-jscs

[gibson042]

cc @markelog

[gibson042]

I'm really not happy with introducing such whitespace into parenthesized expressions (as opposed to parameter/argument lists). Can anything be done about this?

[timmywil]

I agree with you, but I think the point is that we need consistency and the easiest way to get that now is by making the rules as simple as possible for jscs to enforce.

[markelog]

Well, if you remember, we three were outvoted on this matter, for me this very uncomfortable too :-(

[dmethvin]

I think the lack of spaces in the inner parens actually makes it clearer that they are doing grouping, so I am not a fan of extra spaces either. So is this mainly about making a simple rule ("There must be spaces around parens, except the left paren of a function call")?

[gibson042]

The rule that I want would apply to parenthesized expressions specifically instead of only the broader class including function parameters and call expression arguments (all of which are wrapped in parentheses).

[markelog]

@gibson042 distinguishing grouping parentheses with other cases is pretty hard goal to accomplish :-(, otherwise i would did it a long time.

Nevertheless, you are very welcome to take a stab on it yourself

[gibson042]

It should be easier after the San Francisco ESTree concrete syntax discussion. But if you can point me at the relevant code in JSCS, I'll happily take a look sooner.

[markelog]

It should be easier after the San Francisco ESTree concrete syntax discussion.

Not sure if there would be discussion about that :-(

But if you can point me at the relevant code in JSCS, I'll happily take a look sooner.

Parentheses rules - (require | disallow)SpacesInsideParentheses

[gibson042]

jscs-dev/node-jscs#1254

[mgol]

This will need to land to make Sizzle buildable in Node 7 when it comes in 5 months as the current JSCS uses an old version of graceful-fs that will break there.

[timmywil]

It will also need a rebase to resolve conflicts.

[markelog]

old version of graceful-fs that will break there.

Where? Could you provide a link?

[mgol]

@markelog

$ node --version
v6.2.0
$ pm i graceful-fs@3
npm WARN deprecated graceful-fs@3.0.8: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

[markelog]

no-no, i meant "uses" part, where is it declared as dependency?

[mgol]

Ah, OK. It's easy to check. :)

$ npm ls graceful-fs
sizzle@2.3.1-pre /Users/mgol/Documents/projects/public/jquery/sizzle
├─┬ grunt@0.4.5
│ └─┬ glob@3.1.21
│   └── graceful-fs@1.2.3 
├─┬ grunt-jscs@0.6.2
│ └─┬ jscs@1.5.9
│   └─┬ glob@4.0.6
│     └── graceful-fs@3.0.8 
├─┬ karma@0.13.22
│ ├─┬ chokidar@1.5.1
│ │ └─┬ fsevents@1.0.12
│ │   └─┬ node-pre-gyp@0.6.25
│ │     └─┬ tar@2.2.1
│ │       └─┬ fstream@1.0.8
│ │         └── graceful-fs@4.1.3 
│ └── graceful-fs@4.1.4 
└─┬ karma-browserstack-launcher@1.0.0
  └─┬ browserstacktunnel-wrapper@1.4.2
    └─┬ unzip@0.1.11
      └─┬ fstream@0.1.31
        └── graceful-fs@3.0.8 

Wersions <4.0.0 are affected.

[markelog]

it seems we just using old grunt-jscs here, in any case never mind though, we will switch to eslint soon. I think we need to land this ASAP.

So i could start working on moving to eslint. Also, this

This probably deserves its own commit

Is still stands, although i would just remove these changes, we need to update that list anyhow

[gibson042]

I'm closing this. An ESLint replacement would be welcomed, which I can do later if no one else is interested.

[markelog]

I would still merge it though, code style violations would be present either way, i was planing do the eslint migration too, right after core

[markelog]

Since you closed this pull despite my suggestion, i imagine you have your own plan how to do this without duplicating these efforts so i will leave you to it then