Skip to content

Tests: Fix speed/index.html dependencies #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ameshkov
Copy link
Contributor

Currently, sizzle/speed/index.html does not work as there're two missing requirements:
https://github.com/jquery/sizzle/blob/master/speed/speed.js#L6

@mgol
Copy link
Member

mgol commented Mar 13, 2018

This is a next version of PR #417.

There's no need to open a new PR; in the future please fix the branch from which you submitted the original PR and push to it (possibly if --force if you modified some commits); the PR will get updated automatically.

Opening a separate PR after feedback makes it harder to track a discussion.

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the PR itself - how did you install dependencies? package.json should have been modified and it hasn't in this PR.

Please try to use a new npm version (currently 5); preferably you'd use a recent Node.js version, 8 or 9 - then such npm version is included by default.

The repository needs to be at a state where running npm install && grunt npmcopy doesn't introduce any changes to the repo and all the files present in the npmcopy config should be in node_modules after running npm install.

@ameshkov
Copy link
Contributor Author

As for the PR itself - how did you install dependencies? package.json should have been modified and it hasn't in this PR.

Uh, my bad - forgot to include it.

@ameshkov
Copy link
Contributor Author

The repository needs to be at a state where running npm install && grunt npmcopy doesn't introduce any changes to the repo and all the files present in the npmcopy config should be in node_modules after running npm install.

I was confused by multiple changes occurred after grunt npmcopy -- there were old versions of qunit and requirejs -- different from what is declared in package.json. This time I've pushed everything.

@mgol
Copy link
Member

mgol commented Mar 13, 2018

@gibson042 I see package-lock.json is committed in this repo, contrary to us gitignoring it in other repos due to cross-platform npm problems. How do you want to proceed here?

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameshkov as long as we have package-lock.json committed to the repo we need all changes touching package.json being done using recent npm so that package-lock.json gets updates as well, that's why I asked you to do it using latest Node 8 or 9 (i.e. 8.10.0 or 9.8.0). If you're using such a new npm, remember to commit changes to package-lock.json as well.

As for other changes, I think they're good. I was afraid the fact we had mismatched files in external means newer files don't work for us and we haven't noticed but it seems they're fine as tests pass with those changes.

@ameshkov
Copy link
Contributor Author

package-lock is commited: 0226789

@mgol mgol closed this in a9fc696 Oct 25, 2018
@mgol
Copy link
Member

mgol commented Oct 25, 2018

Landed, sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants