-
Notifications
You must be signed in to change notification settings - Fork 948
Tests: Fix speed/index.html dependencies #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a next version of PR #417. There's no need to open a new PR; in the future please fix the branch from which you submitted the original PR and push to it (possibly if Opening a separate PR after feedback makes it harder to track a discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the PR itself - how did you install dependencies? package.json
should have been modified and it hasn't in this PR.
Please try to use a new npm version (currently 5); preferably you'd use a recent Node.js version, 8 or 9 - then such npm version is included by default.
The repository needs to be at a state where running npm install && grunt npmcopy
doesn't introduce any changes to the repo and all the files present in the npmcopy
config should be in node_modules
after running npm install
.
Uh, my bad - forgot to include it. |
I was confused by multiple changes occurred after |
@gibson042 I see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ameshkov as long as we have package-lock.json
committed to the repo we need all changes touching package.json
being done using recent npm so that package-lock.json
gets updates as well, that's why I asked you to do it using latest Node 8 or 9 (i.e. 8.10.0
or 9.8.0
). If you're using such a new npm, remember to commit changes to package-lock.json
as well.
As for other changes, I think they're good. I was afraid the fact we had mismatched files in external
means newer files don't work for us and we haven't noticed but it seems they're fine as tests pass with those changes.
package-lock is commited: 0226789 |
Landed, sorry for the wait. |
Currently, sizzle/speed/index.html does not work as there're two missing requirements:
https://github.com/jquery/sizzle/blob/master/speed/speed.js#L6