Closed
Conversation
markelog
pushed a commit
to markelog/sizzle
that referenced
this pull request
May 26, 2013
…ength >= 1. Fixes jQuery bug #9939. Closes jquery#70.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a shortcut in place that uses the root selector as the context for the rest of the selector if the root selector uses an id. Later there was logic that used the context's parentNode instead if the first part of the selector was hierarchical; it was designed to handle selectors like Sizzle("> div", context) (e95367f).
The parentNode logic was only being used when the parts length equaled 1. That didn't account for selectors like $("#dialog ~ div button:contains('next')"). Changing the parentNode logic to apply when the parts length >= 1 fixes the issue.
I added a test for this new selector and checked that all the other tests pass.
This is my first time working with git submodules; if you'd like me to modify the pull request please let me know.