Skip to content

Fix for #10584: better error text in IE on sizzle syntax errors#77

Closed
ichthyos wants to merge 1 commit intojquery:masterfrom
ichthyos:master
Closed

Fix for #10584: better error text in IE on sizzle syntax errors#77
ichthyos wants to merge 1 commit intojquery:masterfrom
ichthyos:master

Conversation

@ichthyos
Copy link

Bug #10584

As Nicholas Zakas explains, old versions of IE and Safari show less-than-meaningful messages ("Exception thrown and not caught on line X") when strings are thrown instead of instances of the Error object. This commit addresses this issue.

@dmethvin
Copy link
Member

dmethvin commented Nov 3, 2011

Thanks for pointing this out ... I wonder if we should steal this for jQuery.error().

https://github.com/jquery/jquery/blob/master/src/core.js#L533

@timmywil
Copy link
Member

timmywil commented Nov 7, 2011

Landed the switch.

@timmywil timmywil closed this Nov 7, 2011
@ichthyos
Copy link
Author

@dmethvin: Yes, I believe so. I don't have the bandwidth right now to see what else might need to be changed if we make the change in jQuery.error(), but I think it's something we should do.

@timmywil
Copy link
Member

@ichthyos: already done

@ichthyos
Copy link
Author

Excellent. Thanks, timmywil!
On Nov 27, 2011 2:53 PM, "timmywil" <
reply@reply.github.com>
wrote:

@ichthyos: already done


Reply to this email directly or view it on GitHub:
#77 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants