Fix for #10584: better error text in IE on sizzle syntax errors#77
Closed
ichthyos wants to merge 1 commit intojquery:masterfrom
Closed
Fix for #10584: better error text in IE on sizzle syntax errors#77ichthyos wants to merge 1 commit intojquery:masterfrom
ichthyos wants to merge 1 commit intojquery:masterfrom
Conversation
Member
|
Thanks for pointing this out ... I wonder if we should steal this for https://github.com/jquery/jquery/blob/master/src/core.js#L533 |
Member
|
Landed the switch. |
Author
|
@dmethvin: Yes, I believe so. I don't have the bandwidth right now to see what else might need to be changed if we make the change in jQuery.error(), but I think it's something we should do. |
Member
|
@ichthyos: already done |
Author
|
Excellent. Thanks, timmywil!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #10584
As Nicholas Zakas explains, old versions of IE and Safari show less-than-meaningful messages ("Exception thrown and not caught on line X") when strings are thrown instead of instances of the Error object. This commit addresses this issue.