Skip to content

getText respects unbreakable whitespace on IE #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyril-sf wants to merge 2 commits into from
Closed

getText respects unbreakable whitespace on IE #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4260b20
getText respects unbreakable whitespace on IE
Jan 24, 2012
9bae960
fix bug leading to infinite loop
Jan 24, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sizzle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,12 +339,12 @@ var getText = Sizzle.getText = function( elem ) {

if ( nodeType ) {
if ( nodeType === 1 || nodeType === 9 ) {
// Use textContent || innerText for elements
// Use textContent for elements
if ( typeof elem.textContent === 'string' ) {
return elem.textContent;
} else if ( typeof elem.innerText === 'string' ) {
// Replace IE's carriage returns
return elem.innerText.replace( rReturn, '' );
return getText( elem.childNodes ).replace( rReturn, '' );
} else {
// Traverse it's children
for ( elem = elem.firstChild; elem; elem = elem.nextSibling) {
Expand Down
1 change: 1 addition & 0 deletions test/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ <h2 id="qunit-userAgent"></h2>
</div>
</div>
</dl>
<div id="whitespace" style="position:absolute;width:1px;height:1px;overflow:hidden;">Test &nbsp; This</div>
<div id="fx-test-group" style="position:absolute;width:1px;height:1px;overflow:hidden;">
<div id="fx-queue" name="test">
<div id="fadein" class='chain test' name='div'>fadeIn<div>fadeIn</div></div>
Expand Down
5 changes: 4 additions & 1 deletion test/unit/selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ test("pseudo - child", function() {
});

test("pseudo - misc", function() {
expect(19);
expect(20);

t( "Headers", ":header", ["qunit-header", "qunit-banner", "qunit-userAgent"] );
t( "Has Children - :has()", "p:has(a)", ["firstp","ap","en","sap"] );
Expand Down Expand Up @@ -436,6 +436,9 @@ test("pseudo - misc", function() {

document.body.removeChild( tmp );

var whitespace = document.getElementById("whitespace");
equal( Sizzle.getText( whitespace ), 'Test ' + String.fromCharCode(160) + ' This' );

var input = document.createElement("input");
input.type = "text";
input.id = "focus-input";
Expand Down