Tweaks to allow the expose plugin to work when you are rapidly un/exposing something#404
Tweaks to allow the expose plugin to work when you are rapidly un/exposing something#404vitch wants to merge 1 commit intojquerytools:masterfrom
Conversation
…e you are un/exposing an element repeatedly in a small time (e.g in response to mouse movements)
|
Love it ! |
|
Hi, Any chance you could please provide a demo page, with the fix implemented in your version of the code? |
|
I'm afraid the site I did it for isn't live yet and I don't have the files sitting around. You can get the complete modified JS that I used here though: https://raw.github.com/vitch/jquerytools/07b1656763fc7007a31618107598e1ae8fb97d66/src/toolbox/toolbox.expose.js |
|
duclet: If you're reading this, it is a large, quite involved change ; what are your thoughts please? |
|
If I remember rightly the changes weren't very involved - I think that most of what is showing up as a change above is a just whitespace where I had to indent things because they were inside a new conditional... It was a long time ago though so I can't remember exactly what I changed - is there way to run the diff with whitespace ignored? |
|
Hi vitch, Apologies - just noticed: this is based on the current live code. Could you please rebase it on the current dev code, and resubmit for consideration? |
I'm using the expose plugin on a navigation similar to the one on http://www2.goldmansachs.com/ and I needed to expose/ unexpose sometimes rapidly based on user's mouse movements. I did the tweaks in the attached code to enable this...