fix unexpected behavior when calling $('my_selector').tooltip() a second time on altered elements #496
Merged
duclet merged 1 commit intojquerytools:devfrom Mar 21, 2012
Merged
Conversation
rather than checking if any tooltips already exist. this way tooltips on some elements that are reloaded via ajax calls will continue working. the previous code would assume all tooltips still exist if *any* of the tooltips still exist -- even if some of them no longer exist. now, part of a page may be changed and can have new tooltips created instead of only the ones for elements that did not change. resolves: jquerytools#349 Signed-off-by: Adam Mckaig <adam.mckaig@gmail.com>
Contributor
|
Hi ewheeler, Thanks for redoing it - we are close to going into build for 1.2.6 release over the next few days (touch wood!); once 1.2.6 is released, we will look at all pull requests. |
Author
|
Hey alibby251 Should I open a new issue now that old one referring to this pull request is closed (#349)? |
duclet
pushed a commit
that referenced
this pull request
Mar 21, 2012
fix unexpected behavior when calling $('my_selector').tooltip() a second time on altered elements
|
that broke tooltips. see discussion in #1076 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check each tooltip for existence, fixes issue 349
rather than checking if any tooltips already exist.
this way tooltips on some elements that are reloaded via
ajax calls will continue working. the previous code would
assume all tooltips still exist if any of the tooltips still
exist -- even if some of them no longer exist. now, part of a
page may be changed and can have new tooltips created instead
of only the ones for elements that did not change.
resolves: #349
Signed-off-by: Adam Mckaig adam.mckaig@gmail.com