Skip to content

made tabs work with backbone.js#600

Closed
fisherwebdev wants to merge 1 commit intojquerytools:masterfrom
fisherwebdev:master
Closed

made tabs work with backbone.js#600
fisherwebdev wants to merge 1 commit intojquerytools:masterfrom
fisherwebdev:master

Conversation

@fisherwebdev
Copy link

In backbone.js I often find myself with location.hash strings that look like "#users/pg/3". I ran into a conflict where the #users tab was throwing an error and not opening if I loaded the page with the hash string already in place. So I hacked the code to only use the first segment of the location.hash string.

Please use this if you want. I realize this was pretty specific to my project, but I thought maybe some other backbone.js people might find this useful.

Perhaps there is a better, more flexible solution to this issue?

thanks for the great library,
Bill

@duclet duclet mentioned this pull request Jan 13, 2012
@duclet
Copy link

duclet commented Jan 19, 2012

Please make this pull request to dev branch instead.

@alibby251
Copy link
Contributor

Closing - please rebase on the dev branch instead.

@alibby251 alibby251 closed this Feb 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants