made tabs work with backbone.js#600
Closed
fisherwebdev wants to merge 1 commit intojquerytools:masterfrom
Closed
Conversation
Closed
|
Please make this pull request to dev branch instead. |
Contributor
|
Closing - please rebase on the dev branch instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In backbone.js I often find myself with location.hash strings that look like "#users/pg/3". I ran into a conflict where the #users tab was throwing an error and not opening if I loaded the page with the hash string already in place. So I hacked the code to only use the first segment of the location.hash string.
Please use this if you want. I realize this was pretty specific to my project, but I thought maybe some other backbone.js people might find this useful.
Perhaps there is a better, more flexible solution to this issue?
thanks for the great library,
Bill