Breaking test for view helpers#108
Merged
daffl merged 2 commits intojupiterjs:masterfrom Jan 17, 2012
daffl:ejs_helpers
Merged
Conversation
Contributor
Author
|
Ok my bad, of course it doesn't hook up when it is not being added. I updated the tests and now they don't break anymore. The reason why the hookups didn't run for me was the innerShiv I am using. Might be another issue when updating to jQuery 1.7? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems as if the view blocks broke the support for helpers that work on an element attached to $.EJS.Helpers.prototype, breaking test attached.