Closed
Conversation
… based on attribute value
Contributor
|
I like this patch a lot! I'm going to check with the guys, since I'm still nervous about committing directly to the main repo myself. |
Contributor
Author
|
Yeah, I have pull privileges too, but would like if someone else would pull these changes. |
Collaborator
|
meaning me it seems. I think either one of you can pull this if it's tested. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added wrapWith method to model that enables simpler inheritance for subclasses. I believe that wrap method shouldn't be overridden as it holds important functionality. This way user only has to overwrite wrapWith method that should return existing class.
It would be used like this: