Skip to content

form_params() output values problem#115

Merged
ralphholzmann merged 1 commit intojupiterjs:masterfrom
tqwhite:master
Feb 15, 2012
Merged

form_params() output values problem#115
ralphholzmann merged 1 commit intojupiterjs:masterfrom
tqwhite:master

Conversation

@tqwhite
Copy link
Contributor

@tqwhite tqwhite commented Feb 15, 2012

form_params() was incorrectly returning scalar form values as arrays, here it only returns array for checkbox.

ralphholzmann pushed a commit that referenced this pull request Feb 15, 2012
form_params() output values problem
@ralphholzmann ralphholzmann merged commit 2f545c0 into jupiterjs:master Feb 15, 2012
@ralphholzmann
Copy link

Hey, thanks for the pull request! At the same time you submitted this request, I've was writing some tests for these bugs, so I'll pull in your changes, run them against my tests and hopefully we'll be good to go. Thanks.

@tqwhite
Copy link
Contributor Author

tqwhite commented Feb 15, 2012

Terrific. I'm glad to hear it.

Have a good day.

tqii

TQ White II
Website tqwhite.com
Phone 708-763-0100

On Feb 15, 2012, at 10:55 AM, Ralph Holzmann wrote:

Hey, thanks for the pull request! At the same time you submitted this request, I've was writing some tests for these bugs, so I'll pull in your changes, run them against my tests and hopefully we'll be good to go. Thanks.


Reply to this email directly or view it on GitHub:
#115 (comment)

@ralphholzmann
Copy link

@tqwhite The latest master should fix your issue. The expectation for this plugin is, if there's a single named checkbox in your form, it should return the scalar value for that checkbox. However, if there are multiple checkboxes on the form with the same name, it should return an array of scalar values, even if only one checkbox was checked. I've added tests for this to the latest master.

@tqwhite
Copy link
Contributor Author

tqwhite commented Feb 15, 2012

That's great.

Thanks for your work on the framework. It's a great help to me.

best,
tqii

TQ White II
Website tqwhite.com
Phone 708-763-0100

On Feb 15, 2012, at 1:22 PM, Ralph Holzmann wrote:

@tqwhite The latest master should fix your issue. The expectation for this plugin is, if there's a single named checkbox in your form, it should return the scalar value for that checkbox. However, if there are multiple checkboxes on the form with the same name, it should return an array of scalar values, even if only one checkbox was checked. I've added tests for this to the latest master.


Reply to this email directly or view it on GitHub:
#115 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants